Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX - Copy setup script before pip #10910

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eugriner
Copy link

@eugriner eugriner commented Jan 26, 2023

Description

When running pip install . fails to find setup.py, to avoid that first one must copy the setup script to models/research/

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

Tests

Run it inside Google Colab

Test Configuration:

Google Colab's default config

Checklist

@google-cla
Copy link

google-cla bot commented Jan 26, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@laxmareddyp laxmareddyp added the models:research models that come under research directory label Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
models:research models that come under research directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants