To fix nbformat pre-commit instructions...
#2234
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current instructions did not work from me and didn't seem to match the usage in the [pre-commit docs](https://pre-commit.com/). I believe that these changes (almost) address the issue by a) specifying that the YAML contents go in a `.pre-commit-config.yaml` file`; b) clarifying that `.pre-commit-hooks.yaml` is a pre-commit plugin; and c) completing the config YAML by specifying which `hooks` to run (from the plugin) However, this still won't work because `.pre-commit-hooks.yaml` is not located at the root of the repo (as required in https://pre-commit.com/#new-hooks). Am I missing something? E.g. is tools/tensorflow_docs/tools intended as some sort of sub-repo?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current instructions did not work from me and didn't seem to match the usage in the pre-commit docs. I believe that these changes will address the issue by
rev(there's nopre-commitrev so I used the only release tag I found); andhooksto run (from the plugin).However, it still won't work as-is because
.pre-commit-hooks.yamlis not located at the root of the repo (as indicated in https://pre-commit.com/#new-hooks). Am I missing something? E.g. is tools/tensorflow_docs/tools intended as some sort of subrepo?