WIP Upgrade aws provider to 5.x. Create SNS Topic, SNS Sub, and Cloudwatch alarm for worker instance StatusCheckFailed #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdipiazza
commented
Feb 20, 2024
| tags = { | ||
| Name = "${var.project_environment}-${var.project_name}" | ||
| } | ||
| tags_all = { |
There was a problem hiding this comment.
tricia, what is the difference between these?
tdipiazza
commented
Feb 20, 2024
| @@ -76,7 +76,7 @@ resource "aws_lb_target_group" "production" { | |||
| vpc_id = aws_vpc.production-internal.id | |||
| health_check { | |||
| enabled = true | |||
| matcher = "200,301" | |||
| matcher = "200" | |||
There was a problem hiding this comment.
maybe change this back or investigate using https for health check?
There was a problem hiding this comment.
internally we should have a health check endpoint that is better than / and should not redirect. The actual endpoints it is checking are not https, but they will redirect if they think they are being called over http. We might be able to override that by setting X-Forwarded-By and similar
https://docs.aws.amazon.com/elasticloadbalancing/latest/application/x-forwarded-headers.html
samsonasu
reviewed
Feb 20, 2024
| resource "aws_sns_topic_subscription" "ec2-alarm_email_target" { | ||
| topic_arn = aws_sns_topic.ec2-alarm.arn | ||
| protocol = "email" | ||
| endpoint = "alerts@tenforwardconsulting.com" |
There was a problem hiding this comment.
This should probably be a variable instead of hard coded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting up a cloudwatch alarm for ec2 instance statuscheckfailed, currently just on the worker but we might as well do it on web instances too
TODO: