Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed allowed input toggle #269

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bobvandevijver
Copy link
Contributor

Fixes #80 for me. Not sure if it is correct in all scenarios, but I did not find any issues so far.

@bobvandevijver
Copy link
Contributor Author

@Eonasdan Is there anything I can do to get this merged/released?

@paweb88
Copy link

paweb88 commented Feb 3, 2020

pls, @Eonasdan merge this change

@rackberg
Copy link

Thank you for fixing this annoying bug @bobvandevijver
I've switched over to use your version instead for now.

@Eonasdan pls merge this change. Without it, the datetimepicker is useless because the calendar hides immediately after it was shown.

@tonix-tuft
Copy link

This project seems to be unmaintained as the maintainer is unresponsive.
I have sent several pull requests, but they all have been ignored.

I have some plans about developing it further, so I have forked both
tempusdominus/core and tempusdominus/bootstrap-4:

They are also available through NPM:

In these two forks (I worked on the fork branch on both, not on master) I have updated all the NPM dependencies and build scripts,
added some new features and fixed some bugs I have discovered while using Tempus Dominus.

For now, I have left the master branch in my forks intact and the same as in the original repos, as I was waiting for my PR being merged
in the original repos and I am adding patches/bugfixes and new features on the fork branch in both forked projects.

If you have some pending PR you would like to merge, I invite you to fork my forks instead and we can work
on it together in the free time.

@HaroldPutman already sent me a PR which got merged in tonix-tuft/tempusdominus -> tonix-tuft/tempusdominus#1.

P.S.: I have also created a React version of Tempus Dominus Bootstrap, available here (I hope you enjoy it 😃):

@tonix-tuft
Copy link

Hello guys,

I have sent all the PRs we have already merged into my two forks (https://github.com/tonix-tuft/tempusdominus and https://github.com/tonix-tuft/tempusdominus-bootstrap)
to the main repo of Eonasdan directly on master.

I wanna thank @HaroldPutman, @pablo-lp and @zondatw for their contribution.

I think that now it makes sense for us to continue to work on this project in my two forks and from the master branch instead of the fork branch I have created and used so far
because I was waiting for @Eonasdan to merge the features we added to its main repo.

But again, as @Eonasdan was and still is unresponsive, I think it would make sense to continue the development from the two forked repos https://github.com/tonix-tuft/tempusdominus and https://github.com/tonix-tuft/tempusdominus-bootstrap now using the master branch instead of fork as the starting point from which to fork the branches for your PRs.

As always, PRs for new features, bugfixes are welcome! Thank you. Stay tuned.

@Eonasdan
Copy link
Contributor

@tonix-tuft did this get fixed via #360/#340?

@tonix-tuft
Copy link

@Eonasdan I don't think so. I have tried in my fork and the picker is not shown when the input gets the focus. But I don't think that this a big problem, because as soon as the input gets the focus you can press the keyboard's arrows and the picker is shown with the new date you have just selected through the arrow you pressed.

From a UX perspective, even on mobile devices where the user doesn't have a keyboard, I don't see it as problem too because on mobile devices you don't navigate with TAB and as soon as you press the input the datetimepicker is shown (because of the click event being triggered instead of focus).

Anyway, it's up to you and the other guys. For me, this fix can coexist without any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allowInputToggle ??
5 participants