Add workflow_backoff_timer metrics #5910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
approved these changes
May 13, 2024
ychebotarev
pushed a commit
to ychebotarev/temporal
that referenced
this pull request
May 16, 2024
## What changed? Add workflow_backoff_timer metrics with namespace tag. ## Why? For temporalio#5768 Current task_requests{operation="TimerActiveTaskWorkflowBackoffTimer"} does not differentiate if the backoff is due to retry/cron/delayed_start. Current workflow_retry_backoff_timer does not have namespace tag. ## How did you test it? Verify the metrics as: workflow_backoff_timer{backoff_type="Retry",namespace="default",service_name="history"} 1 ## Potential risks No
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add workflow_backoff_timer metrics with namespace tag.
Why?
For #5768
Current task_requests{operation="TimerActiveTaskWorkflowBackoffTimer"} does not differentiate if the backoff is due to retry/cron/delayed_start. Current workflow_retry_backoff_timer does not have namespace tag.
How did you test it?
Verify the metrics as:
workflow_backoff_timer{backoff_type="Retry",namespace="default",service_name="history"} 1
Potential risks
No