Delete unused retry implementations #5909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanos
changed the title
stephanos
force-pushed
the
delete-unused-retry-policy
branch
4 times, most recently
from
2781c3a
to
585aa13
Compare
stephanos
force-pushed
the
delete-unused-retry-policy
branch
from
585aa13
to
6b58f44
Compare
yycptt
approved these changes
May 13, 2024
hazelkim052
added a commit
that referenced
this pull request
May 14, 2024
<!-- Describe what has changed in this PR --> - `ConcurrentRetrier`: deleted, not used anywhere - `TwoPhaseRetryPolicy`: deleted, not used anywhere - `SystemClock`: replaced with `clock.TimeSource` <!-- Tell your future self why have you made these changes --> Less code is good. <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> Compiler. <!-- Assuming the worst case, what can be broken when deploying this change to production? --> <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) -->
hazelkim052
added a commit
that referenced
this pull request
May 14, 2024
<!-- Describe what has changed in this PR --> - `ConcurrentRetrier`: deleted, not used anywhere - `TwoPhaseRetryPolicy`: deleted, not used anywhere - `SystemClock`: replaced with `clock.TimeSource` <!-- Tell your future self why have you made these changes --> Less code is good. <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> Compiler. <!-- Assuming the worst case, what can be broken when deploying this change to production? --> <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) -->
ychebotarev
pushed a commit
to ychebotarev/temporal
that referenced
this pull request
May 16, 2024
## What changed? <!-- Describe what has changed in this PR --> - `ConcurrentRetrier`: deleted, not used anywhere - `TwoPhaseRetryPolicy`: deleted, not used anywhere - `SystemClock`: replaced with `clock.TimeSource` ## Why? <!-- Tell your future self why have you made these changes --> Less code is good. ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> Compiler. ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
ConcurrentRetrier: deleted, not used anywhereTwoPhaseRetryPolicy: deleted, not used anywhereSystemClock: replaced withclock.TimeSourceWhy?
Less code is good.
How did you test it?
Compiler.
Potential risks
Documentation
Is hotfix candidate?