Extract VerifyFirstWorkflowTaskScheduledRequest handler #5904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanos
changed the title
stephanos
force-pushed
the
move-wft-verify
branch
from
c50b5ca
to
c11bf85
Compare
stephanos
commented
May 10, 2024
service/history/api/verifyfirstworkflowtaskscheduled/api_test.go
Outdated
Show resolved
Hide resolved
stephanos
force-pushed
the
move-wft-verify
branch
2 times, most recently
from
ef8dd1c
to
0fa92a7
Compare
yycptt
approved these changes
May 13, 2024
stephanos
force-pushed
the
move-wft-verify
branch
from
0fa92a7
to
ca8b078
Compare
stephanos
force-pushed
the
move-wft-verify
branch
from
ca8b078
to
127717d
Compare
ychebotarev
pushed a commit
to ychebotarev/temporal
that referenced
this pull request
May 16, 2024
) ## What changed? <!-- Describe what has changed in this PR --> Extracted handler for `VerifyFirstWorkflowTaskScheduledRequest` out of `workflow_task_handler_callbacks.go` into its own file. ## Why? <!-- Tell your future self why have you made these changes --> There's no clear benefit to grouping the WFT API handlers all in the - poorly named - file. The PR makes this consistent with the existing API handlers now. ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> Pure refactoring, no behavior change. ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Extracted handler for
VerifyFirstWorkflowTaskScheduledRequestout ofworkflow_task_handler_callbacks.gointo its own file.Why?
There's no clear benefit to grouping the WFT API handlers all in the - poorly named - file. The PR makes this consistent with the existing API handlers now.
How did you test it?
Pure refactoring, no behavior change.
Potential risks
Documentation
Is hotfix candidate?