Fix schedule_action_delay metric for buffered actions #5884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
reviewed
May 17, 2024
alexshtin
approved these changes
May 17, 2024
ychebotarev
pushed a commit
to ychebotarev/temporal
that referenced
this pull request
May 20, 2024
## What changed? - Calculate "delay" for buffered actions from previous action close. - Update a few logs. ## Why? If an action is held up by waiting for a previous action to finish (e.g. BufferOne, BufferAll, CancelOther overlap policies), it's not fair to count the waiting time as the "delay" for that action. ## How did you test it? Tested locally by building up a backlog and checking that the metric didn't increase (and did before this change). Also tested upgrade and downgrade. ## Potential risks This is touching workflow code, but is compatible because: - If it sees nil for the close time or desired time, that's fine, it just falls back to actual time. - All the behavior changes are in logs and metrics only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
If an action is held up by waiting for a previous action to finish (e.g. BufferOne, BufferAll, CancelOther overlap policies), it's not fair to count the waiting time as the "delay" for that action.
How did you test it?
Tested locally by building up a backlog and checking that the metric didn't increase (and did before this change). Also tested upgrade and downgrade.
Potential risks
This is touching workflow code, but is compatible because: