Circuit breaker with dynamic settings #5867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigozhou
force-pushed
the
rodrigozhou/outbound-queue-circuit-breaker-dc
branch
from
71f2501
to
6c8cb37
Compare
bergundy
reviewed
May 7, 2024
rodrigozhou
force-pushed
the
rodrigozhou/outbound-queue-circuit-breaker-dc
branch
3 times, most recently
from
5431523
to
9eea330
Compare
bergundy
reviewed
May 13, 2024
rodrigozhou
force-pushed
the
rodrigozhou/outbound-queue-circuit-breaker-dc
branch
2 times, most recently
from
a1b4dba
to
3e38255
Compare
bergundy
approved these changes
May 14, 2024
rodrigozhou
force-pushed
the
rodrigozhou/outbound-queue-circuit-breaker-dc
branch
from
3e38255
to
65f3af9
Compare
ychebotarev
pushed a commit
to ychebotarev/temporal
that referenced
this pull request
May 16, 2024
## What changed? <!-- Describe what has changed in this PR --> Circuit breaker with dynamic settings: it takes a function that is evaluated whenever `Allow` is called, and if any change happened, then it replaces the circuit breaker with the updated changes (previous state is lost). This makes possible to have the circuit breaker automatically update after a dynamic config change. Added dynamic config for outbound queue circuit breaker. ## Why? <!-- Tell your future self why have you made these changes --> Be able to config by destination. ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Circuit breaker with dynamic settings: it takes a function that is evaluated whenever
Allowis called, and if any change happened, then it replaces the circuit breaker with the updated changes (previous state is lost). This makes possible to have the circuit breaker automatically update after a dynamic config change.Added dynamic config for outbound queue circuit breaker.
Why?
Be able to config by destination.
How did you test it?
Potential risks
Documentation
Is hotfix candidate?