Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic config for the outbound queue host scheduler task rps #5866

Merged
merged 1 commit into from May 13, 2024

Conversation

rodrigozhou
Copy link
Contributor

What changed?

Dynamic config for the outbound queue host scheduler task rps

Why?

Be able to config by destination.

How did you test it?

Potential risks

Documentation

Is hotfix candidate?

@rodrigozhou rodrigozhou requested a review from bergundy May 7, 2024 03:18
@rodrigozhou rodrigozhou requested a review from a team as a code owner May 7, 2024 03:18
Copy link
Member

@bergundy bergundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be a bit more involved to change to use namespace name and not ID.

Copy link
Member

@bergundy bergundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had some minor comments but otherwise LGTM.

@rodrigozhou rodrigozhou merged commit ee3e492 into main May 13, 2024
42 checks passed
@rodrigozhou rodrigozhou deleted the rodrigozhou/rate-limiter-dc branch May 13, 2024 22:45
ychebotarev pushed a commit to ychebotarev/temporal that referenced this pull request May 16, 2024
…alio#5866)

## What changed?
<!-- Describe what has changed in this PR -->
Dynamic config for the outbound queue host scheduler task rps

## Why?
<!-- Tell your future self why have you made these changes -->
Be able to config by destination.

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants