New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attach user metadata from commands to corresponding history events #5857
Conversation
Will let others more familiar with this repo review. But I want to confirm that some features will be present:
|
This is PR is just for commands only (to keep PRs short). I'm working on another PR to include user metadata in all the other areas you mentioned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Workflow task handler logic LGTM
What changed?
In this PR we are attaching the user metadata if found in the command to the corresponding history events that are being created.
Why?
Users need a way to set arbitrary information on workflows and events. This would be later used in the clients to build custom tooling (ex: UI showing additional information about a timer event etc)
How did you test it?
Added unit tests
Potential risks
N/A. It is backward compatible.
Documentation
N/A
Is hotfix candidate?
No