Implement tiered replication stream receiver #5856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hai719
reviewed
May 6, 2024
yux0
reviewed
May 6, 2024
yux0
reviewed
May 6, 2024
yux0
reviewed
May 6, 2024
yux0
reviewed
May 6, 2024
yux0
reviewed
May 10, 2024
yux0
reviewed
May 10, 2024
yux0
reviewed
May 10, 2024
yux0
approved these changes
May 14, 2024
ychebotarev
pushed a commit
to ychebotarev/temporal
that referenced
this pull request
May 16, 2024
## What changed? <!-- Describe what has changed in this PR --> Implement tiered replication stream receiver: 1. Change `receiver.receive` to handle original (single ACK level) and new (prioritized ACK level) properly 2. Change `receiver.ACK` to properly ACK back to sender with proper ACK level. ## Why? <!-- Tell your future self why have you made these changes --> To prioritize different category of replication tasks. ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> integration test. ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> Replication stack will go down. ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> n/a ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) --> no
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Implement tiered replication stream receiver:
receiver.receiveto handle original (single ACK level) and new (prioritized ACK level) properlyreceiver.ACKto properly ACK back to sender with proper ACK level.Why?
To prioritize different category of replication tasks.
How did you test it?
integration test.
Potential risks
Replication stack will go down.
Documentation
n/a
Is hotfix candidate?
no