-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor UpdateListener
#993
Draft
WaffleLapkin
wants to merge
8
commits into
master
Choose a base branch
from
webhook-hint-allowed-updates
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @Hirrolot (teloxidebot has picked a reviewer for you, use r? to override) |
teloxidebot
added
C-main
crate: teloxide
S-waiting-on-review
Status: Awaiting review from the assignee
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author
and removed
S-waiting-on-review
Status: Awaiting review from the assignee
labels
Jan 11, 2024
Finished The MSRV is: 1.74.1 |
WaffleLapkin
added
the
A-update-listeners
Area: update listeners (polling, webhooks)
label
Jan 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-update-listeners
Area: update listeners (polling, webhooks)
C-main
crate: teloxide
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This [is needed to] fix the issue with webhooks not setting allowed updates correctly and thus not getting the updates (lol (lmao)). Sadly, I don't know how to fix the issue without rewriting everything.
I'm not in love with the new code, but it works, I think.
Still needs some cleanup and changelog entries. @teloxidebot author.