adding enum variant to handle unknown 400

[stillbeingnick]

Change Description

Created new ApiError enum variant to handle previously unhanded 400 error from Telegram. This was highlighted in issue #901. A new test case was added so the variant would be included in the "custom_result" test for the ApiError enum.

Doc Notes

The Doc Comment that was added to the variant tries to sum up the use case the error might occur however there is no official guidance on why this would occur so please change/add if we think of a better example of why this error might occur.

Tests ran and passed after change but please let me know if there are any other considerations 👍

[WaffleLapkin]

Did you check if you can still get MessageCantBeDeleted?

[stillbeingnick]

Did you check if you can still get MessageCantBeDeleted?

I did not, but I can.

I just assumed it was a full match on the entire string because serde should visit the entire string but weird things have happened. This error mentioned in the issue did not cause the inverse to happen accidentally logging it as the known MessageCantBeDeleted because of the string similarities but I dont know if that case would be true.

[WaffleLapkin]

@stillbeingnick your assumption is correct, I just want to make sure that the other (old) error actually exists, that Telegram can return it.

[stillbeingnick]

Ill put together a test over the weekend and confirm it still works and update here if that is good with you @WaffleLapkin

[stillbeingnick]

@WaffleLapkin it seems like your hunch might have been correct. Based on my testing I cannot get telegram to return the previous "Message can't be deleted" error message. The only case I have not tested thus far is a message being over 48 hours old. Both group message delete errors and the errors you get trying to delete dice messages that are less than 24 hours old in private chats responds with the "Message can't be deleted for everyone" error message.

I have a commit staged that removes the other variant and leaves only the new MessageCantBeDeletedForEveryone variant. However I wanted to get your thoughts on cleaning this up since this would break code that matches on that ApiError variant.

[Hirrolot]

@WaffleLapkin, what's the status of this PR?

[WaffleLapkin]

Ooops, sorry, I forgot to reply here.

@stillbeingnick IMO we should keep the same variant name and only fix the matching logic, the error message changed but the meaning stayed I think.

[WaffleLapkin]

(@stillbeingnick this is marked as S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author , please use @teloxidebot review once this is ready for review) (learn more about teloxidebot commands)