2.20 Release #255

whitef0x0 · 2017-11-06T04:14:35Z

This is the PR for the 2.20 Release

Description

The 2.20 Release includes the following changes:

Bug affecting slow loading of forms due to high visitor counts is fixed
Field Statistics are Removed from Analytics View
Email Notifications for respondents and form owner added
Static URL mapping for each admin panel added
Coveralls.io support is added for Github PRs
Missing translations for German, Italian and French added
Welcome/Verification emails internationalized into German, Italian, French, English and Spanish
Template engine moved from swig to pug
Test coverage increased from 40% to 60% (mainly due to increase tests for user controller/model)
Broken tests on client and server-side updated and fixed
Submission data fetch delayed to increase form admin page rendering performance
API Route tests added

Motivation and Context

This is the next stable release for TellForm. It incorporates a few new features (most notably email notifications) and some performance enhancements for the web app.

How Has This Been Tested?

This has been tested with server-side, client-side and manual tests (see below for manual test plans).

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing tests passed.

coveralls · 2017-11-12T06:05:25Z

Changes Unknown when pulling 421d3b5 on 2.20 into ** on master**.

…to fixSlowAnalyticsBug

Fix Slow Form Analytics Bug

coveralls · 2017-11-13T23:03:57Z

Changes Unknown when pulling 1f9a0ed on 2.20 into ** on master**.

coveralls · 2017-11-13T23:25:08Z

Changes Unknown when pulling 09d430a on 2.20 into ** on master**.

coveralls · 2017-11-14T00:59:44Z

Changes Unknown when pulling 15a508c on 2.20 into ** on master**.

coveralls · 2017-11-14T06:13:10Z

Changes Unknown when pulling 9d51608 on 2.20 into ** on master**.

Fixed ScrollSpy for fields

coveralls · 2017-11-14T06:21:32Z

Changes Unknown when pulling 499f2c9 on 2.20 into ** on master**.

Fix incorrect responses count for form list view

coveralls · 2017-11-14T07:05:13Z

Changes Unknown when pulling 49141e6 on 2.20 into ** on master**.

whitef0x0 · 2017-11-21T04:35:39Z

app/controllers/helpers.server.controller.js

+			'private_form': ['__v'],
+			'public_user': ['passwordHash', 'password', 'provider', 'salt', 'lastModified', 'created', 'resetPasswordToken', 'resetPasswordExpires', 'token', 'apiKey', '__v'],
+			'private_user': ['passwordHash', 'password', 'provider', 'salt', 'resetPasswordToken', 'resetPasswordExpires', 'token', '__v']
+		};


These should be in defined as constants in constants.js`

whitef0x0 · 2017-11-21T04:36:10Z

app/controllers/helpers.server.controller.js

+'use strict';
+
+module.exports = {
+	removeSensitiveModelData: function(type, object){


Maybe model is a better name for object?

whitef0x0 · 2017-11-21T04:37:09Z

app/controllers/users/users.authentication.server.controller.js

@@ -133,7 +134,7 @@ exports.signup = function(req, res) {

 		// new user created
 		if (newTempUser) {
-			const fn = pug.compileFile(__dirname + "/../../views/verification.email.view.pug");
+			const fn = pug.compileFile(__dirname + '/../../views/verification.email.view.pug');


Shouldn't need to define this twice in one function scope.

whitef0x0 · 2017-11-21T04:37:45Z

app/controllers/users/users.password.server.controller.js

-			const fn = pug.compileFile(__dirname + "/../../views/templates/reset-password-email.server.view.pug");
-			res.locals['url'] = 'http://' + req.headers.host + '/auth/reset/' + token;
+			const fn = pug.compileFile(__dirname + '/../../views/templates/reset-password-email.server.view.pug');
+			res.locals.url = 'http://' + req.headers.host + '/auth/reset/' + token;


Should replace http:// with //

whitef0x0 · 2017-11-21T04:38:25Z

app/controllers/users/users.password.server.controller.js

 			var domain = userEmail.split('@')[1];

-			var obfuscatedUser = user.substring(0, 1) + user.substring(1).replace(/./g, '*');
+			var obfuscatedUser = emailUsername.substring(0, 1) + emailUsername.substring(1).replace(/./g, '*');


Why is the regex in replace() required?

whitef0x0 · 2017-11-21T04:47:32Z

app/tests/form.server.routes.test.js

@@ -167,7 +166,7 @@ describe('Form Routes Unit tests', function() {
 		it(' > should not be able to create a Form if body is empty', function(done) {
 			loginSession.post('/forms')
 				.send({form: null})
-				.expect(400, {"message":"Invalid Input"})
+				.expect(400, {'message':'Invalid Input'})


This should be internationalized.

whitef0x0 · 2017-11-21T04:48:20Z

config/express.js

-		var currIndex = supportedLanguages.indexOf(preferredLanguages[i]);
+	var i, currIndex;
+	for (i = 0; i < preferredLanguages.length; i++) {
+		currIndex = supportedLanguages.indexOf(preferredLanguages[i]);


currIndex should be renamed to something more descriptive

whitef0x0 · 2017-11-21T04:48:55Z

config/express.js

 			if(currLanguage && currLanguage !== supportedLanguage || !currLanguage){
 				res.clearCookie('userLang');
 				res.cookie('userLang', supportedLanguage, { maxAge: 90000, httpOnly: true });
+			} else if(req.user && (!req.cookies.hasOwnProperty('userLang') || req.cookies.userLang !== req.user.language) ){
+				res.cookie('userLang', req.user.language, { maxAge: 90000, httpOnly: true });


userLang cookie settings should be stored in env/*.js

whitef0x0 · 2017-11-21T04:49:28Z

config/logger.js

@@ -76,7 +75,7 @@ logger.getLogOptions = function getLogOptions() {
  var _config = _.clone(config, true);
  var configFileLogger = _config.log.fileLogger;

-  if (!_.has(_config, 'log.fileLogger.directoryPath') || !_.has(_config, 'log.fileLogger.fileName')) {
+  if (process.env.NODE_ENV !== 'test' && !_.has(_config, 'log.fileLogger.directoryPath') || !_.has(_config, 'log.fileLogger.fileName')) {
    console.log('unable to find logging file configuration');


This should be fixed. The logger seems to never be able to find it's configuration.

whitef0x0 · 2017-11-21T04:50:37Z

public/modules/users/tests/unit/controllers/authentication.client.controller.test.js

+ 		}));
+
+		it('$scope.signin should sigin in user with valid credentials', inject(function(Auth) {
+


This test case should be removed.

coveralls · 2017-11-21T21:45:33Z

Changes Unknown when pulling 9ff247f on 2.20 into ** on master**.

coveralls · 2017-11-24T02:56:02Z

Changes Unknown when pulling d8c5b00 on 2.20 into ** on master**.

Sija · 2018-10-06T19:57:01Z

Hi, what's the status on this?

whitef0x0 and others added 30 commits October 5, 2017 21:16

added emailNotifications to form model

346537f

Merge branch 'master' into emailNotifications

ae946bd

got basic emailNotifications to work

00e1d43

Merge branch 'master' into emailNotifications

8de93d4

got edit-submissions-form directive tests to pass

76d6d54

got edit-form-directive tests to pass

538030c

removed duplicate translation keyword for form admin panel

7d65f01

fixed field-icon tests

ebcc0c6

fixed field directive tests

f427092

fixed on-finish-render directive tests

6fbfa35

got user tests to pass

88fbf9e

got all tests to pass

759a4ef

added coveralls support

aa554c8

added helper function to remove sensitive data from forms/users

3dbfe2f

added tests to cover reset password routes

9fffdf5

added test for changing password route

aed7c6c

added test for /users/me routes

15eb66e

fixed hasAuthorization bug for API

99a6cb5

added tests for api routes

e1db98e

removed hasRole and hasAdminRole from passport_helpers

3e3e7cc

got rid of unnessecary user middleware

9a0a301

removed unused code from user.server.model.js

774d256

removed secure configuration

d0d273a

fixed api tests

b2b0917

fixed travis settings

8ea1f63

remove references to i18n-lint

8d9e665

migrating to yarn

26716e2

fixed lcovMerge for travis

fc4d9a1

fixed travis test command

5805c9b

switched travis scripts to yarn

56fda0d

whitef0x0 and others added 3 commits November 13, 2017 14:51

Merge branch '2.20' into fixSlowAnalyticsBug

28fe150

Merge branch 'fixSlowAnalyticsBug' of github.com:tellform/tellform in…

060cd59

…to fixSlowAnalyticsBug

Merge pull request #254 from tellform/fixSlowAnalyticsBug

1f9a0ed

Fix Slow Form Analytics Bug

added cosmetic changes to analytics panel

09d430a

whitef0x0 added 2 commits November 13, 2017 16:52

fixed incorrect responses count for form list view

ed6d917

change name of form assets from form-vendor.min.js to vendor.min.js

15a508c

whitef0x0 added 7 commits November 13, 2017 18:14

moved from on('scroll' to using duScroll for tracking activeField

6848b74

fixed prev and next field buttons

0400124

got validity working for rating field

f5e32e9

fixed form validation bug with radio

2e5bd5b

readded page loader gif for form view

67a3013

fixed shape dropdown for rating field

56bbc68

added email notifications to json form data

9d51608

Merge pull request #261 from tellform/fixedScrollspy

499f2c9

Fixed ScrollSpy for fields

Merge pull request #262 from tellform/fixResponseCountOnFormList

49141e6

Fix incorrect responses count for form list view

whitef0x0 commented Nov 21, 2017

View reviewed changes

Merge branch 'master' into 2.20

9ff247f

whitef0x0 added 2 commits November 23, 2017 18:40

added docker-compose file for development work

5f65451

bumped version in bower.json and package.json

d8c5b00

sidtri approved these changes Mar 25, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

2.20 Release #255

2.20 Release #255

whitef0x0 commented Nov 6, 2017 •

edited

coveralls commented Nov 12, 2017

coveralls commented Nov 13, 2017

coveralls commented Nov 13, 2017

coveralls commented Nov 14, 2017

coveralls commented Nov 14, 2017

coveralls commented Nov 14, 2017

coveralls commented Nov 14, 2017

whitef0x0 Nov 21, 2017

whitef0x0 Nov 21, 2017

whitef0x0 Nov 21, 2017

whitef0x0 Nov 21, 2017

whitef0x0 Nov 21, 2017

whitef0x0 Nov 21, 2017

whitef0x0 Nov 21, 2017

whitef0x0 Nov 21, 2017

whitef0x0 Nov 21, 2017

whitef0x0 Nov 21, 2017

coveralls commented Nov 21, 2017

coveralls commented Nov 24, 2017

Sija commented Oct 6, 2018

		}));

		it('$scope.signin should sigin in user with valid credentials', inject(function(Auth) {

2.20 Release #255

Are you sure you want to change the base?

2.20 Release #255

Conversation

whitef0x0 commented Nov 6, 2017 • edited

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

coveralls commented Nov 12, 2017

coveralls commented Nov 13, 2017

coveralls commented Nov 13, 2017

coveralls commented Nov 14, 2017

coveralls commented Nov 14, 2017

coveralls commented Nov 14, 2017

coveralls commented Nov 14, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Nov 21, 2017

coveralls commented Nov 24, 2017

Sija commented Oct 6, 2018

whitef0x0 commented Nov 6, 2017 •

edited