Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load labels in GetPullRequest #285

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

fatmcgav-depop
Copy link

This commit updates the GetPullRequest func to load the labels attached
to the PR.
Also populate metadata with a comma separated list of labels.

@fatmcgav-depop fatmcgav-depop requested a review from a team as a code owner September 27, 2022 08:47
Node struct {
Commit CommitObject
}
Nodes []struct {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tweak was to standardise on using Nodes rather than Edges, as we're only concerned with the data itself...

https://johnkavanagh.co.uk/writing/gatsby-and-graphql-nodes-vs-edges/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

This commit updates the `GetPullRequest` func to load the `labels` attached
to the PR.
Also populate `metadata` with a comma separated list of labels.
This ensures that all of the commits are checked before returning an error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants