Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): add initial styles for button #1677

Merged
merged 2 commits into from Jul 2, 2020
Merged

fix(button): add initial styles for button #1677

merged 2 commits into from Jul 2, 2020

Conversation

joneff
Copy link
Member

@joneff joneff commented Jul 2, 2020

Related to #798

  • sass variables allow us to have null value and do not generate output when there is no need, which is not the case with css variables;
  • on top of that, css variables, if not provided with fallback and have null value will fallback to prop: initial
    • focus state, per se, is null, so should we provide a fallback to normal state?
  • should we have a sort of handling of css variables, so we use either css or sass variables?
    • prop: k-var( --kendo-css-var, $kendo-sass-var ) and have a $use-css-variables switch...

Apart from that, it looks like it would be doable to have e theme that's based on css variables but can also benefit from sass toolchain.

@joneff joneff marked this pull request as ready for review July 2, 2020 13:31
@joneff
Copy link
Member Author

joneff commented Jul 2, 2020

Merging to have a patch version of the theme, so we have something deployed to test against.

@joneff joneff merged commit 9ba3940 into develop Jul 2, 2020
@joneff joneff deleted the nouvelle branch July 2, 2020 13:39
@joneff joneff added this to the 2020.3 milestone Jan 25, 2022
@joneff joneff added C:Button Enhancement New feature of an existing functionality or an improvement of an existing functionality. T:Nouvelle labels Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Button Enhancement New feature of an existing functionality or an improvement of an existing functionality. T:Nouvelle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant