Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spreadsheet Budgeting app #4274

Merged
merged 6 commits into from May 10, 2024
Merged

Spreadsheet Budgeting app #4274

merged 6 commits into from May 10, 2024

Conversation

yanmariomenev
Copy link
Contributor

Reference and design - private thread

Copy link
Contributor

@JoomFX JoomFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please check the following:

  1. The Login page does not look very good when you change the window dimensions (height/width). It does not look as the suggested design for "962x601" and "360x800"
  2. The "Simple Event" text/logo is not vertically centered in the Header.
  3. On the "Event Budget" page:
    • the "Event Budget" text/header and the background behind it does not seem to be properly positioned when changing the window width/height. It is caused by this code, it seems that it shouldn't be there at all.
    • it is a bit strange that there is a separate DIV, with position: absolute; and background-position: -15vw 4.8vw;, that holds the background image. Usually such backgrounds are applied to the body or in this case it might be the .container element and then leave the browser to take care of its placement on the different resolutions.
    • the page markup is also a big strange. Visually, the Header is first and then comes the "Event Budget" header. However in the markup it is ordered differently (screenshot).
  4. On the "Get Tickets" and "Call for Speakers" pages:
    • the "Get Tickets" and "Apply to Speak at Conference" text/headers and the background behind them do not seem to be properly positioned when changing the window width/height. It is caused by some elements that have a fixed width while (on smaller screens) they should be width: 100%;
    • the page markup here is strange as well, same as the "Event Budget" page above.
  5. Native HTML elements should not be styled like that. Give the particular element a dedicated class and write the styles scoped to this particular class.

@yanmariomenev yanmariomenev merged commit ace96d9 into master May 10, 2024
3 checks passed
@yanmariomenev yanmariomenev deleted the spreadsheet-demo-app branch May 10, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants