Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(Chip): add aria-label and id parameters #2093

Merged
merged 3 commits into from May 13, 2024
Merged

docs(Chip): add aria-label and id parameters #2093

merged 3 commits into from May 13, 2024

Conversation

Tsvetomir-Hr
Copy link
Contributor

Related to : #8861

@Tsvetomir-Hr Tsvetomir-Hr added the merge-to-production Use this label to get a comment to choose whether to merge the PR to production label May 10, 2024
@Tsvetomir-Hr Tsvetomir-Hr requested a review from a team May 10, 2024 08:21
@Tsvetomir-Hr Tsvetomir-Hr self-assigned this May 10, 2024
@Tsvetomir-Hr Tsvetomir-Hr requested a review from a team as a code owner May 10, 2024 08:21
dimodi
dimodi reviewed May 10, 2024
View reviewed changes
components/chip/overview.md Outdated Show resolved Hide resolved
dimodi
dimodi reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@dimodi dimodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need for the merge-to-production label. We don't have RC for the docs site yet.

@telerik telerik deleted a comment from github-actions bot May 10, 2024
@dimodi dimodi removed the merge-to-production Use this label to get a comment to choose whether to merge the PR to production label May 10, 2024
@Tsvetomir-Hr Tsvetomir-Hr requested a review from dimodi May 10, 2024 12:33
@Tsvetomir-Hr Tsvetomir-Hr merged commit 3f3c28d into master May 13, 2024
1 check passed
@github-actions github-actions bot deleted the docs-chip-parameters branch May 13, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikoevska ikoevska ikoevska approved these changes

@dimodi dimodi Awaiting requested review from dimodi

Assignees

@Tsvetomir-Hr Tsvetomir-Hr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Tsvetomir-Hr @dimodi @ikoevska