Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wizard step template #1981

Merged
merged 2 commits into from May 6, 2024
Merged

Wizard step template #1981

merged 2 commits into from May 6, 2024

Conversation

svdimitr
Copy link
Contributor

No description provided.

@svdimitr svdimitr requested a review from a team March 19, 2024 13:59
@svdimitr svdimitr self-assigned this Mar 19, 2024
@svdimitr svdimitr requested a review from a team as a code owner March 19, 2024 13:59
Copy link
Contributor

@ikoevska ikoevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking this as "Request changes" because I think we need to have a discussion around this PR.

Here are my notes on this PR:

  1. I am not sure about the value of this page, as is. It might work better as a section under https://docs.telerik.com/blazor-ui/components/wizard/structure/stepper
  2. It's unclear how this relates to https://docs.telerik.com/blazor-ui/components/stepper/step-template I think you need to better distinguish between the two in both places (or if these are actually the same thing, reuse the content in a smart way, so that you don't create a maintenance hell for yourself).
  3. I would also make sure to discuss and showcase some real-life use cases here.
  4. The titles and headings are misleading. These are not wizard templates, these are step templates for the stepper (and not the actual "pages" of the wizard) and what the user will achieve is customize the look and feel of their stepper. For templates, I would have expected somewhat different information here - for example, the contents of the wizard steps.
  5. Linking could be improved - links to the Stepper page (https://docs.telerik.com/blazor-ui/components/wizard/structure/stepper), to some styling information, to the layout, etc.

@svdimitr
Copy link
Contributor Author

The main purpose of this article is to showcase that there is a template that allows our clients to take control over the rendering of the Steps, part of the Stepper in the Wizard component.

We do not have a real-world example, more than we have for the Step Template in the Stepper component.

The clients will not expect to look for the information in Stepper.

@radkostanev radkostanev merged commit d14a6a7 into master May 6, 2024
1 check passed
@github-actions github-actions bot deleted the wizard-step-template branch May 6, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants