Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Danny,
While the README does mention the intent that you should install the module from the git repo, I blindly tried to install it from pypi today and found that the install was broken, causing a FileNotFound error during the build as the setup.py file needs the requirements*.txt files to be present, but they weren't being copied to the distribution tar:
This MR simply includes those files by adding a MANIFEST.in file (tried using data_files and package_data kwargs in the setup() call to no avail), and bumps the version so that the fix is ready to be uploaded after a tag.
I tested this on a fork that I pushed to the testpypi instance, you can verify that the fix has worked on a clean python install using that distribution if you wish (https://test.pypi.org/project/debug-dpypi-pygdsm/), though you may need to pre-install setuptools via pip (failed otherwise for me as there isn't an upload of setuptools on testpypi):
pip install -i https://test.pypi.org/simple/ debug-dpypi-pygdsm
Cheers,
David