Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send update for multiple measures #826

Merged
merged 11 commits into from
May 23, 2024
Merged

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega commented May 6, 2024

fix for #825
and needs telefonicaid/iotagent-node-lib#1607

  • Mock tests about multiple measures should be updated (now instead of several /v2/op/update just one is sent)

@fgalan
Copy link
Member

fgalan commented May 6, 2024

Functional tests (which I think "live" in the iotagent-node-lib repository) should be expanded to take into account the new functionality? @mapedraza what do you think?

@fgalan
Copy link
Member

fgalan commented May 6, 2024

Functional tests (which I think "live" in the iotagent-node-lib repository) should be expanded to take into account the new functionality? @mapedraza what do you think?

It seems it has been taken into account (see telefonicaid/iotagent-node-lib#1607 (comment))

@AlvaroVega
Copy link
Member Author

AlvaroVega commented May 6, 2024

Functional tests (which I think "live" in the iotagent-node-lib repository) should be expanded to take into account the new functionality? @mapedraza what do you think?

It seems it has been taken into account (see telefonicaid/iotagent-node-lib#1607 (comment))

The test was added in
telefonicaid/iotagent-node-lib@ad5f514 but is not enabled due to lack of support for multiplemeasures tests as @fgalan described in #826 (comment)

@AlvaroVega
Copy link
Member Author

Similar PR for iotagent-ul should be implemented?

@fgalan
Copy link
Member

fgalan commented May 10, 2024

Similar PR for iotagent-ul should be implemented?

I think so, so the IOTAs keep synced in functionality.

@AlvaroVega
Copy link
Member Author

AlvaroVega commented May 13, 2024

Similar PR for iotagent-ul should be implemented?

I think so, so the IOTAs keep synced in functionality.

Not sure if iotagent-ul is able to receive multiple measures at the same time, due to UL protocol format https://github.com/telefonicaid/iotagent-ul/blob/master/docs/usermanual.md#ultralight-20-protocol

@fgalan
Copy link
Member

fgalan commented May 13, 2024

Similar PR for iotagent-ul should be implemented?

I think so, so the IOTAs keep synced in functionality.

Not sure if iotagent-ul is able to receive multiple measures at the same time, due to UL protocol format https://github.com/telefonicaid/iotagent-ul/blob/master/docs/usermanual.md#ultralight-20-protocol

Documentation at https://github.com/telefonicaid/iotagent-ul/blob/master/docs/usermanual.md#measure-payload-syntax describes multimeasure support:

Multiple groups of measures can be combined into a single request, using the # character. In that case, a different NGSI request will be generated for each group of measures. E.g.:

gps|1.2/3.4#t|10

This will generate two NGSI requests for the same entity, one for each one of the values. Each one of those requests can contain any number of attributes.

(The last part of the documentation should be adjusted after the implementation of the new functionality to something like this: "This will generate two elements in the NGSI batch update request (POST /v2/op/update) for the same entity, one for each one of the measures. Each one of those elements can contain any number of attributes.")

CHANGES_NEXT_RELEASE Outdated Show resolved Hide resolved
CHANGES_NEXT_RELEASE Outdated Show resolved Hide resolved
Co-authored-by: Fermín Galán Márquez <fgalan@users.noreply.github.com>
@AlvaroVega
Copy link
Member Author

Similar PR for iotagent-ul should be implemented?

I think so, so the IOTAs keep synced in functionality.

Not sure if iotagent-ul is able to receive multiple measures at the same time, due to UL protocol format https://github.com/telefonicaid/iotagent-ul/blob/master/docs/usermanual.md#ultralight-20-protocol

Documentation at https://github.com/telefonicaid/iotagent-ul/blob/master/docs/usermanual.md#measure-payload-syntax describes multimeasure support:

Multiple groups of measures can be combined into a single request, using the # character. In that case, a different NGSI request will be generated for each group of measures. E.g.:

gps|1.2/3.4#t|10

This will generate two NGSI requests for the same entity, one for each one of the values. Each one of those requests can contain any number of attributes.

(The last part of the documentation should be adjusted after the implementation of the new functionality to something like this: "This will generate two elements in the NGSI batch update request (POST /v2/op/update) for the same entity, one for each one of the measures. Each one of those elements can contain any number of attributes.")

Done twin PR in telefonicaid/iotagent-ul#677

Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit aaab9ff into master May 23, 2024
8 checks passed
@fgalan fgalan deleted the task/send_update_for_multimeasure branch May 23, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants