fix: jumpy map after zoom #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphael-arce
requested review from
ff6347,
Jaszkowic,
vogelino and
aeschi
as code owners
raphael-arce
force-pushed
the
fix/jumpy-map-after-zoom
branch
from
c884d86
to
f49d75a
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: Raphael Arce <raphael.arce@ts.berlin>
raphael-arce
force-pushed
the
fix/jumpy-map-after-zoom
branch
from
f49d75a
to
9858e99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the bug on mobile, when you pinch to zoom, the map jumps sometimes a bit around on zoom end. This is because zoomend used to only set the zoom in the state. However, mapbox can zoom+pan at the same time, which means that using pinch to zoom also slightly moves the center of the map, which then gets not updated correctly in the state