Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: changed validLocations.js #6577

Closed
wants to merge 3 commits into from

Conversation

0xflotus
Copy link
Contributor

@0xflotus 0xflotus commented May 6, 2024

I translated the names of the locations

I translated the names of the locations
@0xflotus 0xflotus requested a review from cgrail as a code owner May 6, 2024 22:51
@cgrail
Copy link
Member

cgrail commented May 7, 2024

I'm not sure about this PR. I usually try to use the englisch name from Wikipedia for a location. But I'm not always consistent about this. Sometimes I've used the local name.
With names like Munich or Vienna, I think more international people would expect those names. But locales would expect München or Wien.
Maybe we also need a translation or alternatives for names.

@prigara @nimzco What do you think?

@cgrail
Copy link
Member

cgrail commented May 22, 2024

Closing it as I got no response. I would leave it with the current naming. Maybe we'll revisit the topic in the future again.

@cgrail cgrail closed this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants