Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in events.mdx #126

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix typo in events.mdx #126

wants to merge 1 commit into from

Conversation

seeekr
Copy link

@seeekr seeekr commented Apr 7, 2024

not sure if I'm making the correct suggestion, but the original code cannot possibly work because there is no member variable.

Copy link

vercel bot commented Apr 7, 2024

@seeekr is attempting to deploy a commit to the teamkeel Team on Vercel.

A member of the Team first needs to authorize it.

@seeekr
Copy link
Author

seeekr commented Apr 7, 2024

oh shoot, it should probably be event.target.data.emailVerified instead?

@davenewza
Copy link
Contributor

oh shoot, it should probably be event.target.data.emailVerified instead?

@seeekr well spotted, and yes, you're correct that it's event.target.data.emailVerified

@davenewza davenewza self-requested a review April 8, 2024 05:49
@@ -116,7 +116,7 @@ export default VerifyEmail(async (ctx, event) => {

case "member.updated":
// Verify their email address if it was changed.
if (!member.emailVerified) {
if (!event.data.emailVerified) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (!event.data.emailVerified) {
if (!event.target.data.emailVerified) {

Copy link
Contributor

@davenewza davenewza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do pop a fix in as per your suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants