Empirical spec phot #14
Conversation
tcjansen
force-pushed
the
empirical-spec-phot
branch
from
c72af8a
to
6f7af78
Compare
|
This demo looks great so far! I look forward to working with you to get the predicted mags closer to the observed mags 😄 |
| @@ -1 +0,0 @@ | |||
| Browse the branches to see the different notebooks I've been working on! | |||
There was a problem hiding this comment.
It'd be great to have some more info in the readme – perhaps a link to your blog, plus a link to the projects page to point out your goals/progress?
|
I said this on Slack but I figure I should have it here for completeness. Will try to do more of a review later, but some initially thoughts:
|
Co-Authored-By: P. L. Lim <2090236+pllim@users.noreply.github.com>
Quoting from the e-mail conversation @bmorris3 and I had with Carlos Rodrigo at SVO, "the [filter curves] that [SVO] provide are the ones including not only the filter transmission but |
empirical_photometry.ipynb
Outdated
| "fluxes = {}\n", | ||
| "for band in sdss_bands:\n", | ||
| " observation = Observation(spectrum, bandpasses[band], force='extrap')\n", | ||
| " flux = observation.effstim('Jy')\n", |
There was a problem hiding this comment.
It'd be great if you introduced effstim before you used it. When I first encountered it, for example, I wasn't sure what it abbreviated, and what calculation it was doing under-the-hood.
There was a problem hiding this comment.
It is documented at https://synphot.readthedocs.io/en/latest/synphot/formulae.html#effective-stimulus . FYI.
| # Delete the file after reading from it | ||
| os.remove(tmp_data_file) | ||
|
|
||
| return trans_waves.to(u.angstrom), transmission |
There was a problem hiding this comment.
Little style nitpick: Python files should end with a blank newline.
There was a problem hiding this comment.
Hmm I'm not sure why github isn't showing my last blank line, as they're definitely there in my text editor (sublime text)...
A place for comments on this example!
The purpose of this example is to take a real spectrum and perform synthetic photometry on it with
synphot.