Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The first notebook #11

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

The first notebook #11

wants to merge 26 commits into from

Conversation

tcjansen
Copy link
Owner

@tcjansen tcjansen commented Jun 5, 2019

A place for reviewing work on this tutorial.

bmorris3
bmorris3 reviewed Jun 6, 2019
View reviewed changes
observing_examples.ipynb Outdated Show resolved Hide resolved
bmorris3
bmorris3 reviewed Jun 6, 2019
View reviewed changes
observing_examples.ipynb Outdated Show resolved Hide resolved
@bmorris3
Copy link

With the latest updates (dfc48f2) it's looking good!

RE pwv_kpno: I think we should get @eteq's opinion before we remove pwv_kpno, but I think you've proven that significant scattering/absorption in the blue is an important factor to include for realistic counts in the optical.

RE #2: I think you can close this issue now, it is as completely addressed as it can be.

RE #3: perhaps this is next on your todo list?

@tcjansen
Copy link
Owner Author

RE #3: perhaps this is next on your todo list?

I've been working on decoding skycalc_cli for replacing pvw_kpno, but since we're going to wait for @eteq's input on that I will get started on including Kepler instead 👍

@bmorris3
Copy link

Great, and now #1 can be next in your queue thanks to the wonderful folks at SVO!

@tcjansen tcjansen added this to In progress in GSoC Progress Jun 12, 2019
pllim
pllim reviewed Jun 13, 2019
View reviewed changes
observing_examples.ipynb Outdated Show resolved Hide resolved
pllim
pllim reviewed Jun 13, 2019
View reviewed changes
observing_examples.ipynb Outdated Show resolved Hide resolved
pllim
pllim reviewed Jun 13, 2019
View reviewed changes
Copy link

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments. GitHub suggestion wasn't matching the LOC properly, so I can't use it to the fullest here.

observing_examples.ipynb Outdated Show resolved Hide resolved
observing_examples.ipynb Outdated Show resolved Hide resolved
observing_examples.ipynb Outdated Show resolved Hide resolved
observing_examples.ipynb Outdated Show resolved Hide resolved
observing_examples.ipynb Show resolved Hide resolved
observing_examples.ipynb Outdated Show resolved Hide resolved
tcjansen and others added 7 commits June 13, 2019 14:58
@tcjansen @pllim
typo fix
6d163ed 
Co-Authored-By: P. L. Lim <2090236+pllim@users.noreply.github.com>
@tcjansen @pllim
changed import style
c8fb9b4 
Co-Authored-By: P. L. Lim <2090236+pllim@users.noreply.github.com>
@tcjansen
Addressed pllim's comments: fixed typos, changed variable names, took…
463965a 
… out binset and forced tapering in Observation calls
@tcjansen
push changes
f015cb9
@tcjansen
small changes made for consistancy
beed31b
@tcjansen
Added a query to SkyCalc for modeling the atmospheric transmission (n…
c700ee9 
…ot finished)
@tcjansen
not sure what to do with skycalc results?
a8049ed
pllim
pllim reviewed Jun 14, 2019
View reviewed changes
observing_examples.ipynb Outdated Show resolved Hide resolved
@tcjansen tcjansen moved this from In progress to Ready for review in GSoC Progress Jun 14, 2019
bmorris3
bmorris3 reviewed Jun 14, 2019
View reviewed changes
observing_examples.ipynb Outdated Show resolved Hide resolved
bmorris3
bmorris3 reviewed Jun 14, 2019
View reviewed changes
observing_examples.ipynb Outdated Show resolved Hide resolved
bmorris3
bmorris3 reviewed Jun 14, 2019
View reviewed changes
observing_examples.ipynb Outdated Show resolved Hide resolved
@bmorris3 bmorris3 mentioned this pull request Jun 16, 2019
Closed
@bmorris3
Copy link

Progress in the last two commits looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pllim pllim pllim left review comments

@bmorris3 bmorris3 bmorris3 left review comments

Assignees
No one assigned
Labels
None yet
Projects
GSoC Progress
  
Ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tcjansen @bmorris3 @pllim