add Promise.try tests #4069
Merged
add Promise.try tests #4069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 tasks
ckknight
reviewed
May 2, 2024
gibson042
approved these changes
May 2, 2024
jridgewell
reviewed
May 2, 2024
ljharb
requested review from
jridgewell,
ckknight and
a team
and removed request for
ckknight
|
Is this waiting for another review? Happy to oblige but it looks like it's already got plenty... OK with me to just fix the linter errors and merge it. (looks like it needs 3x |
|
i'll fix that and then land it :-) |
ljharb
force-pushed
the
promise.try
branch
2 times, most recently
from
15c96ed
to
8b6b0f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tc39/proposal-promise-try#15