Add tests for DurationFormat PR 172 and 167 #3912
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankYFTang
force-pushed
the
DurationFormatOrder
branch
from
0073051
to
0ef5242
Compare
anba
approved these changes
Jan 10, 2024
| }, | ||
| })); | ||
| let p = new Intl.DurationFormat(undefined, opt); | ||
| assert.sameValue( |
There was a problem hiding this comment.
Nit: This could use assert.compareArray. (Requires includes: [compareArray.js] in the frontmatter comment.)
There was a problem hiding this comment.
Yeah, please do change this.
| features: [Intl.DurationFormat] | ||
| ---*/ | ||
|
|
||
| assert.sameValue( |
There was a problem hiding this comment.
assert.compareArray can also be used here.
FrankYFTang
force-pushed
the
DurationFormatOrder
branch
from
f9787c6
to
5934738
Compare
Test the order of resolvedOptions in default setting Also add test to check the reading order of options based on the property returned in the default setting resolvedOptions. tc39/proposal-intl-duration-format#167 tc39/proposal-intl-duration-format#172 https://tc39.es/proposal-intl-duration-format/#sec-Intl.DurationFormat.prototype.resolvedOptions These two PRs are presenting to TC39 2023-09 meeting Swap actual/expected order Update test/intl402/DurationFormat/constructor-option-read-order.js Co-authored-by: André Bargull <andre.bargull@gmail.com> Fix per anba suggestion
FrankYFTang
force-pushed
the
DurationFormatOrder
branch
from
5934738
to
1ed8220
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test the order of resolvedOptions in default setting Also add test to check the reading order of options based on the property returned in the default setting resolvedOptions.
tc39/proposal-intl-duration-format#167
tc39/proposal-intl-duration-format#172
https://tc39.es/proposal-intl-duration-format/#sec-Intl.DurationFormat.prototype.resolvedOptions
These two PRs are presenting to TC39 2023-09 meeting