Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Collapse nonterminals only used for disambiguation #2767

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ptomato
Copy link
Collaborator

@ptomato ptomato commented Feb 2, 2024

Prefer language like "the first |TemporalDecimalFraction|, if present" rather than defining several nonterminals such as |TimeFraction|, |DurationHoursFraction|, etc.

Closes: #2006

Prefer language like "the first |TemporalDecimalFraction|, if present"
rather than defining several nonterminals such as |TimeFraction|,
|DurationHoursFraction|, etc.

Closes: #2006
@ptomato ptomato mentioned this pull request Feb 2, 2024
75 tasks
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (7bd3589) 96.59% compared to head (d9d1722) 96.57%.
Report is 2 commits behind head on main.

Files Patch % Lines
polyfill/lib/ecmascript.mjs 95.34% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2767      +/-   ##
==========================================
- Coverage   96.59%   96.57%   -0.02%     
==========================================
  Files          23       23              
  Lines       12218    12243      +25     
  Branches     2263     2268       +5     
==========================================
+ Hits        11802    11824      +22     
- Misses        356      358       +2     
- Partials       60       61       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collapse grammar nonterminals that are only distinct for the purposes of disambiguation
1 participant