Add GC tests #176
Add GC tests #176
Conversation
|
Something to consider is how strict these tests should be. There's optimisations that can be made if for example things are more lazily opened up for collection by GC. For example switching a complex branch of the graph from "live" to "not-live" can be expensive, so it might make sense to delay such an action, but doing so would keep some things around longer than necessary. |
| @@ -978,6 +978,7 @@ describe("type checks", () => { | |||
| TypeError, | |||
| ); | |||
| expect(Signal.subtle.Watcher.prototype.watch.call(w, s)).toBe(undefined); | |||
| // @ts-expect-error | |||
There was a problem hiding this comment.
why expect error?
whenever I use ts-expect-error, I like to add a comment explaining why (not what (or the specific error -- the specific error is not relevant, but the why it exists is)!)
There was a problem hiding this comment.
If you look below there's a bunch more pre-existing ts-expect-errors. Asides from that I think it's self explanatory in these cases why all of these are present. It's specifically testing areas with incorrect types to produce TypeErrors.
| @@ -484,11 +484,11 @@ describe("Errors", () => { | |||
|
|
|||
| describe("Cycles", () => { | |||
| it("detects trivial cycles", () => { | |||
| const c = new Signal.Computed(() => c.get()); | |||
| const c: Signal.Computed<never> = new Signal.Computed(() => c.get()); | |||
There was a problem hiding this comment.
did something go wrong with inference here?
There was a problem hiding this comment.
Yes it's an infinite loop c is depending on itself. TS wasn't being ran in strict mode before this PR, as the tests are excluded from the main tsconfig.
This adds 3 new tests, 2 of which currently fail:
The impacts of the two failing tests are bounded, so it's more of a memory deficiency than a full on leak.
Required updating viteconfig to expose gc, doesn't appear to work inside the default pool type. Also
WeakRefwasn't usable in spec files, hence adding the nested tsconfig. Doing so enforced strict mode on the spec file so a few further updates to the types were made to appease the type checker.