This repository has been archived by the owner on Jan 25, 2022. It is now read-only.
Normative: Disallow nested destructuring assignment with rest properties #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping, any thoughts here? Is this change unnecessary? |
|
lgtm |
|
All this is doing is extending the same rules for both assignments and declarations? If so, LGTM too |
|
This LGTM as well. BTW, that is what I understand from the previous discussion. |
|
@sebmarkbage Can you merge this? Chrome 61 is shipping with this behavior and I'd feel a lot better if this behavior was part of the spec. |
adrianheine
added a commit
to adrianheine/acorn5-object-spread
that referenced
this pull request
Nov 4, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #43
The previous patch only disabled destructuring binding (e.g.,
let {x, ...{y}} = z); this patch disables destructuring assignment as well (e.g.,{x, ...{y}} = z). Thanks to @gsathya for implementing the initial proposal in V8, which made the mismatch clear, and @ajklein for raising this issue previously. cc @caiolima @saambarati @anba