Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorail: Fix typo #64

Merged
merged 1 commit into from May 13, 2024
Merged

Editorail: Fix typo #64

merged 1 commit into from May 13, 2024

Conversation

FrankYFTang
Copy link
Contributor

stringResult is not defined in Intl.MessageFormat.prototype.format

@FrankYFTang
Copy link
Contributor Author

@eemeli @sffc

ryzokuken
ryzokuken approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM but there's a typo in the commit message

@eemeli eemeli merged commit 7aebc8d into tc39:main May 13, 2024
@FrankYFTang FrankYFTang deleted the patch-1 branch May 13, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eemeli eemeli eemeli approved these changes

@ryzokuken ryzokuken ryzokuken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FrankYFTang @eemeli @ryzokuken