Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normative: turn useGrouping false for hours & smaller units when style is 2-digits or numeric #198

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Normative: turn useGrouping false for hours & smaller units when style is 2-digits or numeric #198

wants to merge 2 commits into from

Conversation

FrankYFTang
Copy link
Collaborator

Fix #192

ben-allen
ben-allen approved these changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@ben-allen ben-allen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sffc
Copy link
Collaborator

sffc commented May 3, 2024

TG2 approval: https://github.com/tc39/ecma402/blob/main/meetings/notes-2024-04-25.md#normative-turn-usegrouping-false-for-hours--smaller-units-when-style-is-2-digits-or-numeric-198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc approved these changes

@ben-allen ben-allen ben-allen approved these changes

@ryzokuken ryzokuken ryzokuken approved these changes

@anba anba Awaiting requested review from anba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@FrankYFTang @sffc @ben-allen @ryzokuken