Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: capitalized previously-uncapitalized instances of "list" and "record" as appropriate #887

Merged

Conversation

ben-allen
Copy link
Collaborator

Intl.DateTimeFormat used "record" and "list" to refer to Records and List should have been used. This PR capitalizes those words as appropriate.

@ben-allen ben-allen requested a review from ryzokuken May 9, 2024 15:06
Copy link
Contributor

@gibson042 gibson042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but currently has merge conflicts.

@ben-allen ben-allen force-pushed the capitalize-datetimeformat-record-and-list branch from 83675d9 to 59b49ed Compare May 14, 2024 17:01
@ben-allen
Copy link
Collaborator Author

LGTM, but currently has merge conflicts.

Rebased!

Copy link
Member

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ryzokuken ryzokuken merged commit ee4d332 into tc39:main May 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants