Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Restsharp #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update Restsharp #18

wants to merge 2 commits into from

Conversation

phalpin
Copy link

@phalpin phalpin commented Dec 14, 2015

Noticed we were having an issue after updating restsharp for another package (twilio) - Restsharp has moved a class over to a different namespace. This should probably be recompiled and a build made for the updated version of restsharp

@mgoodfellow
Copy link
Collaborator

Hi @phalpin,

Thanks for the PR!

This has always been a contraversial one - I have wanted to update it for a while, unfortunately RestSharp introduced a bunch of breaking changes between 104 and 105, and I have found that loads of other packages which also use it never updated - good ol' dependency hell.

Just pondering this at the moment, and I think it might be worth creating a v2 branch from the current master, and support that as a legacy branch (and nuget package) for the short future. I would retire v2, but quite a bit of the Intercom API hasn't been implemented and I also think it might cause other users some issues.

I will have a look at doing this later today.

Thanks!

@phalpin
Copy link
Author

phalpin commented Dec 16, 2015

Alright cool, no worries. I'll keep an eye out on here and nuget - we've got a custom build that's working for our purposes at the moment with the update, will update to whatever becomes avail on nuget.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants