Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transaction duplication #609

Merged

Conversation

SerhiiShovkoplias
Copy link
Contributor

@SerhiiShovkoplias SerhiiShovkoplias commented Sep 21, 2020

Description

fixed transaction duplication
improved gif caching. Now cached gif will be released from memory if memory is overstock
added cell prefetch (tx table view)

Motivation and Context

#594

How Has This Been Tested?

manually

Types of changes

  • UI fix (non-breaking change which fixes a UI issue)
  • Functionality bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Feature refactor (No new feature or functional changes, but performance or technical debt improvements)
  • New Tests
  • Documentation

Checklist:

  • I have tested this on multiple simulator devices with different screensizes.
  • I'm merging against the development branch.
  • Commits have been squashed into one commit with a descriptive commit message
  • I ran all tests before pushing.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added/changed tests to cover my changes if not UI changes.

@SerhiiShovkoplias SerhiiShovkoplias marked this pull request as draft September 23, 2020 08:45
@SerhiiShovkoplias SerhiiShovkoplias marked this pull request as ready for review September 23, 2020 10:22
Copy link
Contributor

@kukabi kukabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comments please.

improved gif caching. Now cached gif will be released from memory if memory is overstock
added cell prefetch
@kukabi kukabi merged commit 460a520 into tari-project:development Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants