Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home view UI tweaks #553

Merged
merged 1 commit into from Aug 12, 2020
Merged

Home view UI tweaks #553

merged 1 commit into from Aug 12, 2020

Conversation

Jasonvdb
Copy link
Contributor

Description

  • Balance labels spacing fix
  • Fixed height and icon offsets of tab bar (adjusted for phones without a notch)
  • Allow the floating panel to higher for phones without a notch
  • Pod updates

Motivation and Context

Related to #536

How Has This Been Tested?

Manaully

Screenshots and/or video clip

Simulator Screen Shot - iPhone Xs 13 6 - 2020-08-12 at 16 45 03
Simulator Screen Shot - iPhone 8 - 2020-08-12 at 16 44 41

Types of changes

  • UI fix (non-breaking change which fixes a UI issue)
  • Functionality bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Feature refactor (No new feature or functional changes, but performance or technical debt improvements)
  • New Tests
  • Documentation

Checklist:

  • I have tested this on multiple simulator devices with different screensizes.
  • I'm merging against the development branch.
  • Commits have been squashed into one commit with a descriptive commit message
  • I ran all tests before pushing.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added/changed tests to cover my changes if not UI changes.

Fixed height and icon offsets of tab bar

Allow the floating panel to higher for phones without a notch

Pod updates
@kukabi kukabi merged commit 2f864af into development Aug 12, 2020
@kukabi kukabi deleted the jason-home-view-polish branch August 12, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants