feat: use precomputation on input set keys #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also tested using an |
AaronFeickert
force-pushed
the
precomputation
branch
from
81600b9
to
d798028
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The curve library supports precomputation, which allows us to evaluate multiscalar multiplication operations using both fixed and dynamic values. This means we can generate precomputation tables for input set keys in advance, and use them when generating and verifying proofs.
This PR adds such functionality. However, it surprisingly results in no efficiency benefit (and possibly even an efficiency regression); this is unclear and could use some digging.
Keeping this open as a draft in case a solution is found.