feat!: update emojis to match yat emojis #6288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI) 3 files 120 suites 37m 41s ⏱️ Results for commit 506ae42. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests)33 tests 33 ✅ 13m 56s ⏱️ Results for commit 506ae42. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
removed
the
P-reviews_required
|
This may give merge conflicts with #6287, so beware! |
hansieodendaal
previously approved these changes
Apr 19, 2024
Comment on lines
80
to
+82
| pub const EMOJI: [char; DICT_SIZE] = [ | ||
| '🌀', '🌂', '🌈', '🌊', '🌋', '🌍', '🌙', '🌝', '🌞', '🌟', '🌠', '🌰', '🌴', '🌵', '🌷', '🌸', '🌹', '🌻', '🌽', | ||
| '🍀', '🍁', '🍄', '🍅', '🍆', '🍇', '🍈', '🍉', '🍊', '🍋', '🍌', '🍍', '🍎', '🍐', '🍑', '🍒', '🍓', '🍔', '🍕', | ||
| '🍗', '🍚', '🍞', '🍟', '🍠', '🍣', '🍦', '🍩', '🍪', '🍫', '🍬', '🍭', '🍯', '🍰', '🍳', '🍴', '🍵', '🍶', '🍷', | ||
| '🍸', '🍹', '🍺', '🍼', '🎀', '🎁', '🎂', '🎃', '🎄', '🎈', '🎉', '🎒', '🎓', '🎠', '🎡', '🎢', '🎣', '🎤', '🎥', | ||
| '🦋', '📟', '🌈', '🌊', '🎯', '🐋', '🌙', '🤔', '🌕', '⭐', '🎋', '🌰', '🌴', '🌵', '🌲', '🌸', '🌹', '🌻', '🌽', |
There was a problem hiding this comment.
Nit: Maybe add a reference to the YAT list?
SWvheerden
dismissed stale reviews from hansieodendaal and AaronFeickert
via
506ae42
SWvheerden
force-pushed
the
sw_update_emojies
branch
from
2fac182
to
506ae42
Compare
ghpbot-tari-project
added
the
P-reviews_required
AaronFeickert
approved these changes
Apr 22, 2024
ghpbot-tari-project
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates the emoji_id emojis to match those used by yat.
Motivation and Context
This will allow users to create a yat from their emoji_id as they now share all characters.
How Has This Been Tested?
unit tests
Breaking Changes
This causes the string emoji representation of tari addresses to be incompatible with previous versions.