Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: ledger blind sign #6264

Draft
wants to merge 38 commits into
base: development
Choose a base branch
from
Draft

WIP: ledger blind sign #6264

wants to merge 38 commits into from
+3,084 −1,217

Conversation

brianp
Copy link
Contributor

@brianp brianp commented Apr 10, 2024

Description

This PR is to share a WIP of the ledger blind sign.

Motivation and Context

How Has This Been Tested?

What process can a PR reviewer use to test or verify this change?

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 10, 2024 •
edited

Test Results (CI)

    3 files    120 suites   35m 27s ⏱️
1 277 tests 1 277 ✅ 0 💤 0 ❌
3 823 runs  3 823 ✅ 0 💤 0 ❌

Results for commit f0fcfef.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Apr 10, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 10, 2024 •
edited

Test Results (Integration tests)

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit f0fcfef.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added the CR-too_long Changes Requested - Your PR is too long label Apr 23, 2024
brianp and others added 23 commits April 26, 2024 17:13
@brianp
Update ledger wallet app scaffold
1e83cb2
@brianp
Trim down the ledger app to needed functions
6d4bc98
@brianp
update payload to ledger script key generation
a13ff5d
@brianp
Only use ledger for outputs that have managed keys
d74cf1d
@brianp
Moved ledger device app to new folder
4b038db
@brianp
Add ledger interface library
ca17f2c
@brianp
Add public key function to ledger
362eb31
@brianp
fetch the script key pair for derivation
bc9797d
@SWvheerden @brianp
change script key derivation
c610ee8
@brianp
Make the software wallet use priv and pub key types
7929ca1
@brianp
Code fork for script signing on the ledger
9dc3e57
@brianp
Allow the transport to be reused
621deef
@brianp
Generate the ComAndPubSig entirely on the ledger
c954816
@SWvheerden @brianp
derive script key (#5)
59040b0
@brianp
minor changes
862fbeb
@brianp
fmt
f94285f
@brianp
Only hit the ledger for derived keys
9bf614a
@brianp
Mask alpha on the ledger
c9e0b80
@brianp
Move key derivation into helper
bd2fadf
@brianp
Remove GetPrivateKey function at no point should the private key be r…
6d125dc 
…evealed
@brianp
Update script offset key manager function
7566ccf
@brianp
Only append and read the account once per process
4cb78c8
@brianp
Update the key derivation params
ec338cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CR-too_long Changes Requested - Your PR is too long P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brianp @ghpbot-tari-project @SWvheerden