Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump nightly version #6133

Closed

Conversation

AaronFeickert
Copy link
Collaborator

@AaronFeickert AaronFeickert commented Feb 6, 2024

Description

Consistent with other repositories in the ecosystem, this PR bumps the nightly toolchain to nightly-2024-02-01. It addresses many updated lints.

Motivation and Context

Other repositories are pinning their nightly toolchains at nightly-2024-02-01 due to a curve library issue. It seems like a good time to bump the nightly version here as well.

How Has This Been Tested?

Tested via CI.

What process can a PR reviewer use to test or verify this change?

Ensure that CI and any other relevant build processes succeed.

@AaronFeickert AaronFeickert requested a review from a team as a code owner February 6, 2024 21:35
Copy link

github-actions bot commented Feb 6, 2024

Test Results (CI)

226 tests   225 ✅  8m 6s ⏱️
 14 suites    0 💤
  1 files      1 ❌

For more details on these failures, see this check.

Results for commit 67d8947.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Feb 6, 2024
Copy link

github-actions bot commented Feb 6, 2024

Test Results (Integration tests)

12 tests   12 ✅  1m 1s ⏱️
 2 suites   0 💤
 2 files     0 ❌
 1 errors

For more details on these parsing errors, see this check.

Results for commit 67d8947.

♻️ This comment has been updated with latest results.

@AaronFeickert AaronFeickert requested a review from a team as a code owner February 6, 2024 23:17
@AaronFeickert
Copy link
Collaborator Author

There are two warning lints that identify Arcs whose underlying types are not Send + Sync. It's unclear if it's safe to ignore these.

@AaronFeickert AaronFeickert marked this pull request as draft February 6, 2024 23:20
@AaronFeickert
Copy link
Collaborator Author

After discussion, it sounds like while an eventual update to the nightly toolchain may be useful to avoid ongoing technical debt (and in case of a future curve library update), it isn't particularly crucial at this time.

Closing.

@AaronFeickert AaronFeickert deleted the bump-nightly branch February 7, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants