[wip]chore: fix cucumber test #6087
Open
+19
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringhandler
previously approved these changes
Jan 19, 2024
ghpbot-tari-project
added
the
P-acks_required
Test Results (Integration tests) 2 files + 2 11 suites +11 28m 51s ⏱️ + 28m 51s For more details on these failures, see this check. Results for commit a58cff4. ± Comparison against base commit b48a830. ♻️ This comment has been updated with latest results. |
Test Results (CI) 3 files 120 suites 33m 21s ⏱️ Results for commit a58cff4. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
the
P-reviews_required
Comment on lines
+129
to
+135
| // fs::create_dir_all(&test_run_dir).unwrap(); | ||
| // | ||
| // for entry in fs::read_dir(log_dir).unwrap() { | ||
| // let file = entry.unwrap(); | ||
| // fs::copy(file.path(), test_run_dir.join(file.file_name())).unwrap(); | ||
| // fs::remove_file(file.path()).unwrap(); | ||
| // } |
There was a problem hiding this comment.
Why remove this? Is it because of unwrap failing the test?
There was a problem hiding this comment.
Yeah, same question here.
There was a problem hiding this comment.
I believe it is related
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
makes the last log, a best effort.
If the mutex is held in a another thread which is sometimes is, the lock will fail, failing the entire test, and its just a logging issue.