Future curve library updates will break nightly CI #6138
Comments
SWvheerden
pushed a commit
that referenced
this issue
May 17, 2024
Description --- Updates `tari-crypto` and associated dependencies. Bumps the nightly toolchain. Fixes lints. Removes unused code. Closes #6138. Motivation and Context --- Updates to `tari-crypto` and related dependencies allow for a return to the upstream curve library. This also requires bumping the nightly toolchain, which brings fun new lints that need to be fixed. This PR addresses all of these, and removes unused code. How Has This Been Tested? --- Existing tests pass. What process can a PR reviewer use to test or verify this change? --- Watch that CI! Ensure that the removed code is unused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a tracking issue to note that any updates of the curve library fork to upstream version 4.1.2 or later will break on the current nightly toolchain.
The current version of the curve library used for the fork breaks nightly CI starting with the
nightly-2024-02-05toolchain. A recent upstream PR fixes this, but is not backwards compatible.This means that if the curve library fork is ever updated to include the fix, it will break this repository's nightly CI. The ecosystem's repositories will need to move to
stableor at leastnightly-2024-02-05if this happens.The text was updated successfully, but these errors were encountered: