Lints

base_layer/contacts/Cargo.toml

@@ -23,7 +23,7 @@ diesel = { version = "2.0.3", features = ["sqlite", "serde_json", "chrono", "64-
 diesel_migrations = "2.0.0"
 futures = { version = "^0.3.1", features = ["compat", "std"] }
 log = "0.4.6"
-num-derive = "0.3.3"
+num-derive = "0.4.2"
 num-traits = "0.2.15"
 prost = "0.11.9"
 rand = "0.8"

base_layer/core/Cargo.toml

@@ -74,7 +74,7 @@ log-mdc = "0.1.0"
 monero = { version = "0.20.0", features = ["serde-crate"], optional = true }
 newtype-ops = "0.1.4"
 num-traits = "0.2.15"
-num-derive = "0.3.3"
+num-derive = "0.4.2"
 num-format = "0.4.0"
 once_cell = "1.8.0"
 prost = "0.11.9"

base_layer/core/src/proof_of_work/proof_of_work.rs

@@ -29,6 +29,7 @@ use tari_utilities::hex::Hex;
 
 use crate::proof_of_work::PowAlgorithm;
 
+#[allow(dead_code)]
 pub trait AchievedDifficulty {}
 
 /// The proof of work data structure that is included in the block header. There's some non-Rustlike redundancy here

base_layer/p2p/src/dns/mock.rs

@@ -87,6 +87,7 @@ pub fn message(query: Query, answers: Vec<Record>, name_servers: Vec<Record>, ad
 }
 
 pub trait OnSend: Clone + Send + Sync + 'static {
+    #[allow(dead_code)]
     fn on_send<E>(
         &mut self,
         response: Result<DnsResponse, E>,

base_layer/p2p/src/services/liveness/state.rs

@@ -162,7 +162,7 @@ impl LivenessState {
 
     /// Returns true if the nonce is inflight, otherwise false
     pub fn is_inflight(&self, nonce: u64) -> bool {
-        self.inflight_pings.get(&nonce).is_some()
+        self.inflight_pings.contains_key(&nonce)
     }
 
     /// Records a pong. Specifically, the pong counter is incremented and
@@ -345,8 +345,8 @@ mod test {
         state.add_inflight_ping(2, peer2.clone());
         state.add_inflight_ping(3, peer2.clone());
 
-        assert!(state.failed_pings.get(&peer1).is_none());
-        assert!(state.failed_pings.get(&peer2).is_none());
+        assert!(!state.failed_pings.contains_key(&peer1));
+        assert!(!state.failed_pings.contains_key(&peer2));
 
         // MAX_INFLIGHT_TTL passes
         for n in [1, 2, 3] {
@@ -363,6 +363,6 @@ mod test {
         assert!(state.record_pong(2, &peer2).is_none());
         let n = state.failed_pings.get(&peer1).unwrap();
         assert_eq!(*n, 1);
-        assert!(state.failed_pings.get(&peer2).is_none());
+        assert!(!state.failed_pings.contains_key(&peer2));
     }
 }

base_layer/wallet/src/lib.rs

@@ -17,7 +17,6 @@ pub mod output_manager_service;
 pub mod storage;
 pub mod test_utils;
 pub mod transaction_service;
-pub mod types;
 
 pub use tari_common_types::types::WalletHasher;
 pub mod util;

comms/dht/examples/graphing_utilities/utilities.rs

@@ -43,7 +43,7 @@ static GRAPH_FRAME_NUM: Lazy<Mutex<HashMap<String, usize>>> = Lazy::new(|| Mutex
 fn get_next_frame_num(name: &str) -> usize {
     let mut map = GRAPH_FRAME_NUM.lock().unwrap();
     let current: usize;
-    match (*map).get_mut(&name.to_string()) {
+    match (*map).get_mut(name) {
         None => {
             current = 0;
             (*map).insert(name.to_string(), 1);

lints.toml

@@ -15,7 +15,6 @@ deny = [
     # Common mistakes
     'clippy::await_holding_lock',
     'unused_variables',
-    'unused_imports',
     'dead_code',
     'unused_extern_crates',
     'unused_must_use',
@@ -70,4 +69,5 @@ allow = [
     # `assert!(!foo(bar))` is misread the majority of the time, while `assert_eq!(foo(bar), false)` is crystal clear
     'clippy::bool-assert-comparison',
     'clippy::blocks_in_conditions',
+    'unused_imports', # TODO: DENY THIS
 ]