New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(indexer): fix events query #797
Open
stringhandler
wants to merge
9
commits into
tari-project:development
Choose a base branch
from
stringhandler:st-fix-events
base: development
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(indexer): fix events query #797
stringhandler
wants to merge
9
commits into
tari-project:development
from
stringhandler:st-fix-events
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI)83 tests - 404 82 ✅ - 405 1h 11m 20s ⏱️ - 48m 50s For more details on these failures, see this check. Results for commit c09633a. ± Comparison against base commit 3cfbf6e. This pull request removes 404 tests.
♻️ This comment has been updated with latest results. |
# Conflicts: # integration_tests/tests/steps/indexer.rs
# Conflicts: # integration_tests/tests/steps/indexer.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the GraphQL query
getEventsForComponent
.Motivation and Context
Previously this would work the first time it's called, but fail in subsequent attempts. This is because one of the queries was missing columns in the sql.
How Has This Been Tested?
Run an indexer, and call
getEventsForComponent
via GraphQLWhat process can a PR reviewer use to test or verify this change?
As above
Breaking Changes