ci: move to stable toolchain #223
Draft
+144
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFeickert
force-pushed
the
stable-ci
branch
from
8233723
to
ceecc52
Compare
SWvheerden
reviewed
Feb 9, 2024
| - name: Check code | ||
| run: cargo +stable check --release --all-targets | ||
| - name: Check code (no default features) | ||
| run: cargo +stable check --release --no-default-features | ||
| # This check here is to ensure that it builds for no-std rust targets | ||
| - name: Check code (no-std) | ||
| run: cargo +${{ env.nightly }} check --no-default-features --target=thumbv8m.main-none-eabi -Zavoid-dev-deps |
There was a problem hiding this comment.
Dont change this target at all, it was chosen very specifically to match this: https://github.com/tari-project/ledger/tree/main/ledger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, CI uses a mix of stable and nightly toolchains. Nightly is included primarily to support
no_stdchecks, but this is only necessary due to arandtest dependency.This PR makes changes to allow a move to stable across the board. To do this, it replaces the use of
randin all tests with a random number generator fromrand_chacha, which has the side effect of making all tests deterministic.However, due to a desire to keep a secure random number generator in doctests, we add an optional
randfeature whose only role is to enablerand_core::OsRng. Doctests that use this are gated on this feature.The
no_stdtarget has been changed towasm32-unknown-unknownfor easier local testing; it should still meet the goal.Finally, note that some formatting rules are not available on stable, so we still use the latest nightly for this.