Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature addition: Color fill star icon when toggled to favorite #553

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

prajwalkulkarni
Copy link

@prajwalkulkarni prajwalkulkarni commented Jan 28, 2022

Description

The current version makes it difficult for the end-user to identify if a starred note is actually added to favorites or not, this is because there's no UI change when a note is starred from the bottom menu bar, this would make the user click the star option multiple times which is a bad UX. A simple fix would be to reflect the changes when a note is added/removed from favorites, like filling the star color when a note is toggled to be favorite, and remove the filling when it is removed from favorites.
This PR adds this feature to improve the UX, and also this behavior is consistent across all the components (Bottom menu bar, Notes list and, context menu).
The toggle state is also accessed from the redux store(Where required) instead of having a separate function that determines the toggle state. Moreover, this is achieved, without having to make any changes or updates to the stylesheets, by making use of fill props of the icon.

Closes #511

Browser checklist

This PR has been tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge

Testing checklist

  • End-to-end tests have been created if necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add note to favorite animation
1 participant