Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#57 Fix defaultDate functionality #58

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

peterox
Copy link
Contributor

@peterox peterox commented Apr 14, 2016

Fix for issue #57.

I don't believe that there is a need to set the date to null so the change should not effect any functionality.

@op16
Copy link
Contributor

op16 commented Apr 26, 2016

Sorry, but it has side effects: the Close and Clear actions keep the default date unchanged (the previous start of range).

@peterox
Copy link
Contributor Author

peterox commented Apr 27, 2016

I don't understand what you mean. Can you please better explain what is broken because of this change.

@op16
Copy link
Contributor

op16 commented Apr 27, 2016

  1. comment out your customization of beforeShowDay() (not sure if this step is necessary, just to make sure you are seeing what I'm seeing)
  2. select a range and press Apply
  3. open the picker again and press Clear
  4. open the picker again and notice the previous start of range looks different with your fix (because it is marked as current-day)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants