Refactor tamarin-prover package #621
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this is too much please let me know. I'll try to split it into smaller PRs. |
|
hi @arcz , thank you, this looks great, but I want to run this by some of the people working on big feature branches at the moment, as the potential for clashes seems fairly substantial. |
|
I extracted the first chunk here #622. |
This was referenced May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is sort of a follow up to #618. I did a refactor to the main package (code under /src) using the
GHC2021and a few modern extensions for records. I focused on unifying code style, reducing duplication and hints from hlint. There should be no semantic changes.I know the diff is massive but I got a bit carried away, sorry 馃槄 If the changes are welcome I can take a look at the other packages.